Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create embedding cache interface and impl RocksDB cache #2858

Closed
wants to merge 1 commit into from

Conversation

kaiyuan-li
Copy link
Contributor

Summary:

  1. created an Embedding Cache interface that has the basic get and set.
  2. implemented the RocksDB Embedding Cache by wrapping / reusing existing EmbeddingRocksDB.
  3. added unit test

Next:

  1. Create the DRAM implementation (with CacheLib) which will call this RocksDB cache upon cache miss.
  2. Integrate the DRAM cache into existing models to test it out.
  3. (P1) Implement the parameter service cache.

For full picture, please see D59407784 for reference

Differential Revision: D59764493

Summary:
1. created an Embedding Cache interface that has the basic `get` and `set`.
1. implemented the RocksDB Embedding Cache by wrapping / reusing existing EmbeddingRocksDB.
1. added unit test

Next:
1. Create the DRAM implementation (with CacheLib) which will call this RocksDB cache upon cache miss.
1. Integrate the DRAM cache into existing models to test it out.
1. (P1) Implement the parameter service cache.

For full picture, please see D59407784 for reference

Differential Revision: D59764493
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59764493

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit e73ab22
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6697efa2b2898300081e8027
😎 Deploy Preview https://deploy-preview-2858--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 296af0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants