Remove redundant torch.abs in sim check #2822
Conversation
Summary: The absolute value is redundant because the next step involves squaring the differences, which makes all values non-negative.
|
Hi @acoskunses-AMD! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@spcyppt has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: The absolute value is redundant because the next step involves squaring the differences, which makes all values non-negative. X-link: #2822 Pulled By: spcyppt X-link: facebookresearch/FBGEMM#109 spcyppt Reviewed By: q10 Differential Revision: D61492832 fbshipit-source-id: 9208ba1c6c572b500e4e2c505ec6fc8a93a01c77
Summary:
The absolute value is redundant because
the next step involves squaring the differences,
which makes all values non-negative.