fix two sparsenn failures #2613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57050715 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdhirsh
added a commit
to bdhirsh/FBGEMM
that referenced
this pull request
May 21, 2024
Summary: there were two failures in the dashboard: (1) `torch._custom_op.impl.get_ctx` appears to not exist (or get imported properly). From some grepping it looks like we pull from `torch.library.get_ctx` in most of the codebase (2) an error about branching on truthy numpy arrays in one of the sparsenn tests: I just coerced the numpy array into a boolean. Reviewed By: williamwen42 Differential Revision: D57050715
|
This pull request was exported from Phabricator. Differential Revision: D57050715 |
Summary: there were two failures in the dashboard: (1) `torch._custom_op.impl.get_ctx` appears to not exist (or get imported properly). From some grepping it looks like we pull from `torch.library.get_ctx` in most of the codebase (2) an error about branching on truthy numpy arrays in one of the sparsenn tests: I just coerced the numpy array into a boolean. Reviewed By: williamwen42 Differential Revision: D57050715
|
This pull request was exported from Phabricator. Differential Revision: D57050715 |
|
This pull request has been merged in 66efb75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
there were two failures in the dashboard:
(1)
torch._custom_op.impl.get_ctxappears to not exist (or get imported properly). From some grepping it looks like we pull fromtorch.library.get_ctxin most of the codebase(2) an error about branching on truthy numpy arrays in one of the sparsenn tests: I just coerced the numpy array into a boolean.
Reviewed By: williamwen42
Differential Revision: D57050715