Add OptimItem in TBE codegen #2518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff abstracts the optimization arguments in TBE code generation scripts by introducing the `OptimizerArgsSetItem` dataclass. This allows us to avoid updating function and variable annotations every time we add or remove arguments from the optimizer args. Differential Revision: D56192736
|
This pull request was exported from Phabricator. Differential Revision: D56192736 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 19, 2024
Summary: This diff abstracts the optimization arguments in TBE code generation scripts by introducing the `OptimizerArgsSetItem` dataclass. This allows us to avoid updating function and variable annotations every time we add or remove arguments from the optimizer args. Reviewed By: spcyppt Differential Revision: D56192736
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 19, 2024
Summary: This diff abstracts the optimization arguments in TBE code generation scripts by introducing the `OptimizerArgsSetItem` dataclass. This allows us to avoid updating function and variable annotations every time we add or remove arguments from the optimizer args. Reviewed By: spcyppt Differential Revision: D56192736
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 19, 2024
Summary: This diff abstracts the optimization arguments in TBE code generation scripts by introducing the `OptimizerArgsSetItem` dataclass. This allows us to avoid updating function and variable annotations every time we add or remove arguments from the optimizer args. Reviewed By: spcyppt Differential Revision: D56192736
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 19, 2024
Summary: This diff abstracts the optimization arguments in TBE code generation scripts by introducing the `OptimizerArgsSetItem` dataclass. This allows us to avoid updating function and variable annotations every time we add or remove arguments from the optimizer args. Reviewed By: spcyppt Differential Revision: D56192736
|
This pull request has been merged in 9180dd4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff abstracts the optimization arguments in TBE code generation
scripts by introducing the
OptimizerArgsSetItemdataclass. This allowsus to avoid updating function and variable annotations every time we
add or remove arguments from the optimizer args.
Differential Revision: D56192736