Improve perf of kernel: _block_bucketize_sparse_features_cuda_kernel1 #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AlbertDachiChen
force-pushed
the
export-D53585964
branch
2 times, most recently
from
577c47f to
4e4fd52
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
AlbertDachiChen
force-pushed
the
export-D53585964
branch
from
4e4fd52 to
8df7b3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
AlbertDachiChen
force-pushed
the
export-D53585964
branch
from
8df7b3e to
efdc754
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
AlbertDachiChen
force-pushed
the
export-D53585964
branch
from
efdc754 to
fa2eb58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
AlbertDachiChen
added a commit
to AlbertDachiChen/FBGEMM
that referenced
this pull request
Feb 16, 2024
…pytorch#2331) Summary: As titled, this diffs changes kernel to parallelize the work of _block_bucketize_sparse_features_cuda_kernel1 within a row. The context here is that for IG DV365 models, we have row that is really long which makes the kernel slow. I need to think more about how to improve _block_bucketize_sparse_features_cuda_kernel**2**. Publishing the changes for kernel 1 first because it is significantly faster {F1455708370} Reviewed By: sryap Differential Revision: D53585964
AlbertDachiChen
force-pushed
the
export-D53585964
branch
from
fa2eb58 to
5c08185
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
…pytorch#2331) Summary: As titled, this diffs changes kernel to parallelize the work of _block_bucketize_sparse_features_cuda_kernel1 within a row. The context here is that for IG DV365 models, we have row that is really long which makes the kernel slow. I need to think more about how to improve _block_bucketize_sparse_features_cuda_kernel**2**. Publishing the changes for kernel 1 first because it is significantly faster {F1455708370} Reviewed By: sryap Differential Revision: D53585964
AlbertDachiChen
force-pushed
the
export-D53585964
branch
from
5c08185 to
bb92b3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585964 |
|
This pull request has been merged in bbf83f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled, this diffs changes kernel to parallelize the work of _block_bucketize_sparse_features_cuda_kernel1 within a row.
The context here is that for IG DV365 models, we have row that is really long which makes the kernel slow.
I need to think more about how to improve _block_bucketize_sparse_features_cuda_kernel2. Publishing the changes for kernel 1 first because it is significantly faster
{F1455708370}
Differential Revision: D53585964