Fix fbgemm::permute_1D_sparse_data's aliasing behavior #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D51711257 |
zou3519
force-pushed
the
export-D51711257
branch
from
52ded5e to
f10d3a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51711257 |
…iant (pytorch#2180) Summary: - We fix fbgemm::permute_1d_sparse_data's implementation to never return views. The schema for the operator promises that it is functional. This was causing flaky tests. - fbgemm::permute_2d_sparse_data already has that fix applied, so we just remove the skip Differential Revision: D51711257
zou3519
force-pushed
the
export-D51711257
branch
from
f10d3a3 to
4b9fe96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51711257 |
williamwen42
approved these changes
Nov 30, 2023
|
This pull request has been merged in 1c93072. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The schema for this operator promises that it is functional (that is, it does
not return output Tensors that are views on the inputs). There is a fast-path
that does return views on the input. We change it to return clones instead of
views. fbgemm::permute_2d_sparse_data already has this fix; looks like we just
didn't apply it to fbgemm::permute_1d_sparse_data
Differential Revision: D51711257