Delete copy and move operations of some Matrix classes #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
cyyever
changed the title
|
@cyyever can I trouble you rebase the branch to top of tree |
|
@q10 Done |
cyyever
force-pushed
the
copy_assignable
branch
from
de66999
to
d28636c
Compare
cyyever
changed the title
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Oct 31, 2023
Summary: For those matrices managing their buffers, the copy and move operations should be deleted to avoid default versions generated by the compiler. Another solution is to manage the buffer ownership in user defined versions, but deleting them is simpler given that no memory corruption has been found since it can be inferred that they are not used. Another solution is use std::share_ptr to manager buffers. However, it will incur some atomic operations on the reference counter, which is not desirable . Pull Request resolved: pytorch#2100 Reviewed By: spcyppt Differential Revision: D50822752 Pulled By: q10 fbshipit-source-id: be291b2aeaf19424df3b4aab4cf7feaca8278396
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Oct 31, 2023
Summary: Pull Request resolved: pytorch#2103 For those matrices managing their buffers, the copy and move operations should be deleted to avoid default versions generated by the compiler. Another solution is to manage the buffer ownership in user defined versions, but deleting them is simpler given that no memory corruption has been found since it can be inferred that they are not used. Another solution is use std::share_ptr to manager buffers. However, it will incur some atomic operations on the reference counter, which is not desirable . Pull Request resolved: pytorch#2100 Reviewed By: spcyppt Differential Revision: D50822752 Pulled By: q10 fbshipit-source-id: 05eb6036248b3f19727477bfcaec1f5dc42d9a65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those matrices managing their buffers, the copy and move operations should be deleted to avoid default versions generated by the compiler. Another solution is to manage the buffer ownership in user defined versions, but deleting them is simpler given that no memory corruption has been found since it can be inferred that they are not used.
Another solution is use std::share_ptr to manager buffers. However, it will incur some atomic operations on the reference counter, which is not desirable .