Turn on opcheck for split_table_batched_embeddings_test #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 24, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728
ezyang
force-pushed
the
export-D50613728
branch
from
d4e8511 to
59d1489
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728 fbshipit-source-id: ccb8f7c6d0fbbdb929191d16d3782e3ff5476729
ezyang
force-pushed
the
export-D50613728
branch
from
59d1489 to
71702ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728 fbshipit-source-id: 40b2d898fc0c83abc10e6a74f5e73da9fed331c0
ezyang
force-pushed
the
export-D50613728
branch
from
71702ec to
2c6dca6
Compare
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728
ezyang
force-pushed
the
export-D50613728
branch
from
2c6dca6 to
565685f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
ezyang
force-pushed
the
export-D50613728
branch
from
565685f to
2a64072
Compare
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728
ezyang
force-pushed
the
export-D50613728
branch
from
2a64072 to
7f7e76f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
ezyang
force-pushed
the
export-D50613728
branch
from
7f7e76f to
1ff1a6e
Compare
ezyang
added a commit
to ezyang/FBGEMM
that referenced
this pull request
Oct 25, 2023
Summary: Pull Request resolved: pytorch#2092 Differential Revision: D50613728
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
Summary: Pull Request resolved: pytorch#2087 Reviewed By: zou3519 Differential Revision: D50584541
Summary: Pull Request resolved: pytorch#2090 Reviewed By: zou3519 Differential Revision: D50586828
Summary: I'm not entirely sure about some of these (e.g., bin_ctr_in_use_after) but it should be harmless enough to accept symbolic SymInt at all these sites. Reviewed By: zou3519 Differential Revision: D50587015
Summary: Pull Request resolved: pytorch#2092 Reviewed By: zou3519 Differential Revision: D50613728
ezyang
force-pushed
the
export-D50613728
branch
from
1ff1a6e to
d2859ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50613728 |
|
This pull request has been merged in 6c2be88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D50613728