Enable bf16 output in TBE CPU kernel for other input types #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 26, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: b49b8f8bfc6932c5665daa4b810fcea1f306a077
excelle08
force-pushed
the
export-D47028021
branch
from
39fee8a
to
06ad33b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 27, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: b52a672c7aeb175746b62ea6dfbbad81eec14975
excelle08
force-pushed
the
export-D47028021
branch
from
06ad33b
to
4595c55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 28, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 73802deb5e17d4da4b84c7d75c6a5c3c415b46d6
excelle08
force-pushed
the
export-D47028021
branch
from
4595c55
to
ebde42d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 28, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 94c48bd4fc68da13505d8080c5773e214da0fef4
excelle08
force-pushed
the
export-D47028021
branch
from
ebde42d
to
07aa523
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 30, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 6f759ef4b072e6e8b9d78b550497c1ebe1b3483d
excelle08
force-pushed
the
export-D47028021
branch
from
07aa523
to
fd86ff8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 30, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 8721ba1aa097702ae6a0844d312929124ed3448e
excelle08
force-pushed
the
export-D47028021
branch
from
fd86ff8
to
bdb0f81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 5, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: cc09c0c60cca6f4b72036d2e28e452f4f9334b5c
excelle08
force-pushed
the
export-D47028021
branch
from
bdb0f81
to
6f779ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 5, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 14f0a8a33b906ac531a8bb5d212f74b7eb2cf00d
excelle08
force-pushed
the
export-D47028021
branch
from
6f779ef
to
2ab6f2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 5, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: aca192f78900a09eee6cda2d660cf4761c765deb
excelle08
force-pushed
the
export-D47028021
branch
from
2ab6f2f
to
4a69c37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 5, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: 61301ea038ffa358550dccc346e4df3096781901
excelle08
force-pushed
the
export-D47028021
branch
from
4a69c37
to
dae96c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 6, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Differential Revision: D47028021 fbshipit-source-id: d8b83bb3fb4c477c361a1f062e3c254d840e01d2
excelle08
force-pushed
the
export-D47028021
branch
from
dae96c5
to
9c62202
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 7, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Reviewed By: sryap Differential Revision: D47028021 fbshipit-source-id: 26bd071461ae65ceafc0d27c2233ec340bb24180
excelle08
force-pushed
the
export-D47028021
branch
from
9c62202
to
a7e673b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
excelle08
added a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 7, 2023
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Reviewed By: sryap Differential Revision: D47028021 fbshipit-source-id: b71c123e4f76d92f0e85bb0e00512b57a02695c5
excelle08
force-pushed
the
export-D47028021
branch
from
a7e673b
to
b6708d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
) Summary: Pull Request resolved: pytorch#1851 Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32 Reviewed By: sryap Differential Revision: D47028021 fbshipit-source-id: 8c3f09113541ce813a424cdf2f39a4679cd2115d
excelle08
force-pushed
the
export-D47028021
branch
from
b6708d1
to
374b556
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028021 |
|
This pull request has been merged in ed4fe6e. |
This was referenced Oct 20, 2023
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 21, 2023
By updating fbgemm submodule Add regression test for it (though it can probably be limited to just CPU as reproducer only works if num_threads is 1) Also, update call-sites to `fbgemm:: GenerateEmbeddingSpMDM` to pass `isbf16` twice, to match API changes introduced in pytorch/FBGEMM#1851 Fixes #111189 and #111710 Pull Request resolved: #111672 Approved by: https://github.com/Skylion007
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
By updating fbgemm submodule Add regression test for it (though it can probably be limited to just CPU as reproducer only works if num_threads is 1) Also, update call-sites to `fbgemm:: GenerateEmbeddingSpMDM` to pass `isbf16` twice, to match API changes introduced in pytorch/FBGEMM#1851 Fixes pytorch#111189 and pytorch#111710 Pull Request resolved: pytorch#111672 Approved by: https://github.com/Skylion007
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
By updating fbgemm submodule Add regression test for it (though it can probably be limited to just CPU as reproducer only works if num_threads is 1) Also, update call-sites to `fbgemm:: GenerateEmbeddingSpMDM` to pass `isbf16` twice, to match API changes introduced in pytorch/FBGEMM#1851 Fixes pytorch#111189 and pytorch#111710 Pull Request resolved: pytorch#111672 Approved by: https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Enable bf16 output support in TBE CPU kernel when the input weight type is int8/fp8/fp16/fp32
Differential Revision: D47028021