Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T145005253] Improvements to OSS builds and the Release Process #1627

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Mar 4, 2023

Summary:

  • Add support for CUDA 11.8 in the OSS builds
  • Annotate the package wheels with Python 3.9 and 3.10 support tags
  • Update setup.py to auto-derive the package version from the git information (namely tags) to allow us for fast tag-and-release
  • Check for the actual presence of NVIDIA drivers in OSS builds, and error out with friendly message instead of cryptic RuntimeError: No such operator fbgemm::jagged_2d_to_dense errors when fbgemm_gpu is installed and loaded on a system with a GPU but without GPU drivers installed

@netlify
Copy link

netlify bot commented Mar 4, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit fd4ac90
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6407eeea6048cb0008ae5017

@q10 q10 force-pushed the bm/T145005253/build-scripts-6 branch 4 times, most recently from e0c0928 to 05f29f8 Compare March 7, 2023 05:43
@q10 q10 changed the title Bm/t145005253/build scripts 6 [T145005253] Improvements to OSS builds and the Release Process Mar 7, 2023
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/T145005253/build-scripts-6 branch 2 times, most recently from e0d0be8 to 30e1874 Compare March 7, 2023 21:35
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
- Add support for CUDA 11.8 in the OSS builds
- Annotate the package wheels with Python 3.9 and 3.10 support tags
- Update `setup.py` to auto-derive the package version from the git information (namely tags) to allow us for fast tag-and-release
- Check for the actual presence of NVIDIA drivers in OSS builds, and error out with friendly message instead of cryptic `RuntimeError: No such operator fbgemm::jagged_2d_to_dense` errors when `fbgemm_gpu` is installed and loaded on a system with a GPU but without GPU drivers installed

Pull Request resolved: pytorch#1627

Reviewed By: brad-mengchi, shintaro-iwasaki

Differential Revision: D43868995

Pulled By: q10

fbshipit-source-id: 7843622c8415df847fc1c25775f084875e1324b6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43868995

@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in 6a63116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants