Update asynchronous_complete_cumsum to support 2D inputs #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D42956351 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D42956351 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 2, 2023
Summary: Pull Request resolved: pytorch#1573 Before this diff, `asynchronous_complete_cumsum` only supports 1D inputs. This diff adds the 2D input support. Differential Revision: D42956351 fbshipit-source-id: 2a6e7107b919411a8cffe17f13ac12de7fc74c24
sryap
force-pushed
the
export-D42956351
branch
from
2a1d184
to
8f647da
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 2, 2023
Summary: Pull Request resolved: pytorch#1573 Before this diff, `asynchronous_complete_cumsum` only supports 1D inputs. This diff adds the 2D input support. Reviewed By: yinghai, jianyuh Differential Revision: D42956351 fbshipit-source-id: 5d8c6c600a95df572d8535175de131b493b48b43
sryap
force-pushed
the
export-D42956351
branch
from
8f647da
to
2089ca0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42956351 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 2, 2023
Summary: Pull Request resolved: pytorch#1573 Before this diff, `asynchronous_complete_cumsum` only supports 1D inputs. This diff adds the 2D input support. Reviewed By: yinghai, jianyuh Differential Revision: D42956351 fbshipit-source-id: a039a7f998aeabf5d6dc09e210e66dc5b9aafc09
sryap
force-pushed
the
export-D42956351
branch
from
2089ca0
to
e88969b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42956351 |
Summary: Pull Request resolved: pytorch#1573 Before this diff, `asynchronous_complete_cumsum` only supports 1D inputs. This diff adds the 2D input support. Reviewed By: yinghai, jianyuh Differential Revision: D42956351 fbshipit-source-id: e5f4846d62250106d657f0a3a29058e1d51ef3ce
sryap
force-pushed
the
export-D42956351
branch
from
e88969b
to
b53ffb5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42956351 |
|
This pull request has been merged in 64c6a5b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before this diff,
asynchronous_complete_cumsumonly supports 1Dinputs. This diff adds the 2D input support.
Differential Revision: D42956351