Use int32_t for kThreadGroupSize in warp_per_row #1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-stroopwafel-199537 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D39568569 |
Summary: Pull Request resolved: pytorch#1332 Use int32_t for kThreadGroupSize instead of size_t. Using size_t causes a slowdown in some cases. Reviewed By: jianyuh Differential Revision: D39568569 fbshipit-source-id: 7a1e56f96a0e9929fb9600156f22fe3c58a3c59e
|
This pull request was exported from Phabricator. Differential Revision: D39568569 |
sryap
force-pushed
the
export-D39568569
branch
from
9411539
to
bb74666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use int32_t for kThreadGroupSize instead of size_t. Using size_t
causes a slowdown in some cases.
Differential Revision: D39568569