Skip to content

Commit

Permalink
Unpin Python binaries from Python 3.8 (#2108)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2108

Unpin Python binaries from Python 3.8.  This is a re-attempt of D50814040

Reviewed By: spcyppt

Differential Revision: D50907864

fbshipit-source-id: d190b43e38b46bd9173077d75e1b8b7b2f58aa90
  • Loading branch information
q10 authored and facebook-github-bot committed Nov 2, 2023
1 parent 824ef10 commit cbb3130
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/fbgemm_gpu_test.bash
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ test_setup_conda_environment () {
if [ "$pytorch_variant_type" == "" ]; then
echo "Usage: ${FUNCNAME[0]} ENV_NAME PYTHON_VERSION PYTORCH_INSTALLER PYTORCH_VERSION PYTORCH_VARIANT_TYPE [PYTORCH_VARIANT_VERSION]"
echo "Example(s):"
echo " ${FUNCNAME[0]} build_env 3.8 pip test cuda 11.8.0 # Setup environment with pytorch-test for Python 3.8 + CUDA 11.8.0"
echo " ${FUNCNAME[0]} build_env 3.10 pip test cuda 12.1.0 # Setup environment with pytorch-test for Python 3.10 + CUDA 12.1.0"
return 1
else
echo "################################################################################"
Expand Down
4 changes: 2 additions & 2 deletions .github/scripts/test_torchrec.bash
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ usage () {
echo "PACKAGE_NAME : output package name of TorchRec (e.g., torchrec_nightly)"
echo " Note: TorchRec is sensitive to its package name"
echo " e.g., torchrec needs fbgemm-gpu while torchrec_nightly needs fbgemm-gpu-nightly"
echo "PYTHON_VERSION : Python version (e.g., 3.8, 3.9, 3.10)"
echo "PYTHON_VERSION : Python version (e.g., 3.10)"
echo "PYTORCH_CHANNEL_NAME: PyTorch's channel name (e.g., pytorch-nightly, pytorch-test (=pre-release), pytorch (=stable release))"
echo "CUDA_VERSION : PyTorch's CUDA version (e.g., 11.6, 11.7)"
echo "CUDA_VERSION : PyTorch's CUDA version (e.g., 12.1)"
echo "FBGEMM_WHEEL_PATH : path to FBGEMM_GPU's wheel file"
echo "MINICONDA_PREFIX : path to install Miniconda (default: \$HOME/miniconda)"
echo "Example: Python 3.10 + PyTorch nightly (CUDA 12.1), install miniconda at \$HOME/miniconda, using dist/fbgemm_gpu_nightly.whl"
Expand Down
1 change: 1 addition & 0 deletions fbgemm_gpu/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ def main(argv: List[str]) -> None:
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Topic :: Scientific/Engineering :: Artificial Intelligence",
],
)
Expand Down

0 comments on commit cbb3130

Please sign in to comment.