Fix MSVC inconsistent DLL linkage

pytorch · Oct 5, 2023 · 687ab54 · 687ab54
1 parent 2b04682
commit 687ab54
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/src/EmbeddingSpMDMAvx2.cc b/src/EmbeddingSpMDMAvx2.cc
@@ -6,7 +6,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include <cassert>
+#define FBGEMM_EXPORTS
 #include <cmath>
 #include "RefImplementations.h"
 #include "fbgemm/FbgemmEmbedding.h"

diff --git a/src/FbgemmBfloat16ConvertAvx2.cc b/src/FbgemmBfloat16ConvertAvx2.cc
@@ -10,6 +10,7 @@
     (defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)))
 #include <immintrin.h>
 #endif
+#define FBGEMM_EXPORTS
 #include "fbgemm/FbgemmConvert.h"
 
 namespace fbgemm {

diff --git a/src/FbgemmBfloat16ConvertAvx512.cc b/src/FbgemmBfloat16ConvertAvx512.cc
@@ -10,6 +10,7 @@
     (defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)))
 #include <immintrin.h>
 #endif
+#define FBGEMM_EXPORTS
 #include "fbgemm/FbgemmConvert.h"
 
 namespace fbgemm {

diff --git a/src/FbgemmFloat16ConvertAvx2.cc b/src/FbgemmFloat16ConvertAvx2.cc
@@ -10,6 +10,7 @@
     (defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)))
 #include <immintrin.h>
 #endif
+#define FBGEMM_EXPORTS
 #include "fbgemm/FbgemmConvert.h"
 
 namespace fbgemm {

diff --git a/src/FbgemmFloat16ConvertAvx512.cc b/src/FbgemmFloat16ConvertAvx512.cc
@@ -10,6 +10,7 @@
     (defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)))
 #include <immintrin.h>
 #endif
+#define FBGEMM_EXPORTS
 #include "fbgemm/FbgemmConvert.h"
 
 namespace fbgemm {