Handle XML namespaces in worksheets #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using local_name, which throws away the namespace prefix, identify the configured namespace prefix (if there is one) and use that when looking for nodes in the SAX parsing loop.
|
After thinking about it more, I decided that it makes more sense to use the approach taken for the shared strings dictionary when parsing the sheet's rows as well. Using Making the row parsing logic namespace aware seems like the better solution. |
pythonicrubyist
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue with parsing an XLSX when the nodes are namespaced (e.g.
<x:row>).This PR addresses that issue by using thelocal_namemethod when looking forrow,c,vandtnodes. Thenamemethod includes the namespace, e.g.x:row, butlocal_namewill strip the namespace prefix, allowing the existing comparison logic to work.This PR addresses that issue by identifying the namespace prefix (if there is one) while SAX parsing the sheet and looking for nodes whose name includes the prefix.
Additionally, when the shared strings dictionary is built, this PR identifies the namespace prefix (if there is one) and includes the namespace in the CSS query used to parse the dictionary. An alternative approach would be to call
remove_namespaces!on the document, but that seems a bit heavy handed.