Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop out of sequence detection #38

Closed
michael-o opened this issue Aug 12, 2021 · 1 comment · Fixed by #44
Closed

Drop out of sequence detection #38

michael-o opened this issue Aug 12, 2021 · 1 comment · Fixed by #44
Labels
stale

Comments

@michael-o
Copy link
Contributor

It is not clear why out of sequence detection is enabled because we don't use the security context to wrap any messages, but for authentication only.
See here:

In the common case where a context initiator is transmitting several sequential data packets to the acceptor,
some mechanisms allow the context acceptor to check whether or not the packets are arriving as they should:
in the right order, and with no unwanted duplication of packets (shown in Figure 1–9). The acceptor checks for
these two conditions when it verifies a packet's validity or when it unwraps a packet; see Unwrapping and
Verification for more information.

We don't use unwrap and MIC here, this option can be dropped.

Can provide a PR for that.
@stale stale bot added the stale label Sep 9, 2021
@stale stale bot closed this as completed Sep 23, 2021
michael-o added a commit to michael-o/requests-gssapi that referenced this issue Dec 22, 2021
@michael-o
Drop out of sequence detection (pythongssapi#38)
26628af 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.
michael-o added a commit to michael-o/requests-gssapi that referenced this issue Dec 22, 2021
@michael-o
Drop out of sequence detection (pythongssapi#38)
ba75642 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.

This fixes pythongssapi#38
@michael-o michael-o mentioned this issue Dec 22, 2021
Merged
@michael-o
Copy link
Contributor Author

Please reopen.

michael-o added a commit to michael-o/requests-gssapi that referenced this issue Dec 22, 2021
@michael-o
Drop out of sequence detection (pythongssapi#38)
5aa04ff 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.

This fixes pythongssapi#38

Signed-off-by: Michael Osipov <[email protected]>
michael-o added a commit to michael-o/requests-gssapi that referenced this issue Dec 22, 2021
@michael-o
Drop out of sequence detection (pythongssapi#38)
f40385e 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.

This fixes pythongssapi#38

Signed-off-by: Michael Osipov <[email protected]>
michael-o added a commit to michael-o/requests-gssapi that referenced this issue Jan 13, 2022
@michael-o
Drop out of sequence detection (pythongssapi#38)
a9909c9 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.

This fixes pythongssapi#38

Signed-off-by: Michael Osipov <[email protected]>
jborean93 pushed a commit that referenced this issue Jan 13, 2022
@michael-o @jborean93
Drop out of sequence detection (#38)
7af32f3 
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.

This fixes #38

Signed-off-by: Michael Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop out of sequence detection (#38) michael-o/requests-gssapi
1 participant
@michael-o