Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip a problematic test on CPython 3.12.0b1 #200

Merged
merged 2 commits into from
May 26, 2023
Merged

Skip a problematic test on CPython 3.12.0b1 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
563784a
Skip a problematic test on CPython 3.12.0b1
AlexWaygood May 26, 2023
aac8e0a
Docs
AlexWaygood May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Unreleased

- Skip a problematic test on Python 3.12.0b1. The test fails on 3.12.0b1 due to
a bug in CPython, which will be fixed in 3.12.0b2. The
`typing_extensions` test suite now passes on 3.12.0b1.

# Release 4.6.2 (May 25, 2023)

- Fix use of `@deprecated` on classes with `__new__` but no `__init__`.
Expand Down
4 changes: 4 additions & 0 deletions src/test_typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2267,6 +2267,10 @@ class Foo: ...
del f.x
self.assertNotIsInstance(f, HasX)

@skipIf(
sys.version_info == (3, 12, 0, 'beta', 1),
"CPython had a bug in 3.12.0b1"
)
def test_protocols_isinstance_generic_classes(self):
T = TypeVar("T")

Expand Down