-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dj-database-url to 1.3.* #9975
Conversation
Release: https://pypi.org/pypi/dj-database-url/1.3.0 Homepage: https://github.com/jazzband/dj-database-url Diff: jazzband/dj-database-url@v1.2.0...v1.3.0 Stubsabot analysis of the diff between the two releases: - 0 public Python files have been added. - 0 files included in typeshed's stubs have been deleted. - 1 file included in typeshed's stubs has been modified or renamed: `dj_database_url.py`. - Total lines of Python code added: 151. - Total lines of Python code deleted: 98. If stubtest fails for this PR: - Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR) - Fix stubtest failures in another PR, then close this PR Note that you will need to close and re-open the PR in order to trigger CI
It looks like they added inline types in the latest release and added a We should figure out what's going on rather than trying to update our stubs, since they're obviously obsolete now. |
There's no way to add a py.typed to a single file module. They'd need to make it a package (and then also specify package_data in setup.py) |
Good point, that'll be the bug then! |
Opened an issue at: |
In the meantime, I think I will merge this anyway, actually. The updates required from us are very trivial, and the inline types at runtime are still not visible to users, so until jazzband/dj-database-url#214 is resolved, it's still worth our stubs being as up-to-date as possible. |
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Release: https://pypi.org/pypi/dj-database-url/1.3.0
Homepage: https://github.com/jazzband/dj-database-url
Diff: jazzband/dj-database-url@v1.2.0...v1.3.0
Stubsabot analysis of the diff between the two releases:
dj_database_url.py
.If stubtest fails for this PR:
Note that you will need to close and re-open the PR in order to trigger CI