[openpyxl] Annotate Worksheet and other items #9892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll update #9511 if this gets merged first. |
srittau
commented
Mar 16, 2023
| @overload | ||
| def __getitem__(self, key: int | slice) -> tuple[Cell, ...]: ... | ||
| @overload | ||
| def __getitem__(self, key: str) -> Any: ... # Cell | tuple[Cell, ...] |
There was a problem hiding this comment.
Another instance where python/typing#566 would come in handy.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Mar 22, 2023
|
|
||
| class BoundDictionary(defaultdict[_KT, _VT], Generic[_KT, _VT]): | ||
| reference: str | None | ||
| def __init__(self, reference: str | None = None, *args, **kw) -> None: ... |
There was a problem hiding this comment.
The *args, **kwargs here just forward on the arguments to defaultdict.__init__, but we have 8 overloads for that. So I'm fine with keeping this as it is for now.
Comment on lines
137
to
140
| @property | ||
| def rows(self) -> Generator[Cell, None, None]: ... | ||
| def rows(self) -> Generator[tuple[Cell, ...], None, None]: ... | ||
| @property | ||
| def values(self) -> Generator[str | float | datetime | None, None, None]: ... | ||
| def values(self) -> Generator[tuple[str | float | datetime | None, ...], None, None]: ... |
There was a problem hiding this comment.
@Avasam's annotations for these are slightly different:
AlexWaygood
reviewed
Mar 23, 2023
Revert change to auto_type, might find a better solution in the future.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Mar 23, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Mar 23, 2023
Co-authored-by: Alex Waygood <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.