Simplify pyrightconfig.json , add missing comments and extra strict settings in all pyright configs
#9714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
AlexWaygood
reviewed
Feb 12, 2023
Incidentally also test generic params inferred from __init__ call
AlexWaygood
reviewed
Feb 12, 2023
Avasam
changed the title
pyrightconfig.json , add missing comments and extra strict settings in all pyright configs
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit simply simplifies
pyrightconfig.json, adds missing comments to all 3 files and moves a TODO inpyrightconfig.stricter.jsonso that both base and stricter configs are identical below the// Extra strict settingscomment.Second commit turns on settings that are not on by default even with
"typeCheckingMode": "strict". Or excplicitely disables them if should be."reportShadowedImports": "none"has an added advantage of stopping Pylance from highlighting entire stdlib stub files:Fixed a small
reportUninitializedInstanceVariableissue in tests.