Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytype_test: Mark typeshed-external dependencies as missing. #9486

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

rchen152
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the new pytype release is out).

@srittau
Copy link
Collaborator

srittau commented Jan 10, 2023

I think adding types-setuptools to requirements-tests.txt should fix the build error.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! (Ignore my earlier bogus comment that I deleted)

tests/pytype_test.py Outdated Show resolved Hide resolved
@Avasam
Copy link
Collaborator

Avasam commented Jan 10, 2023

#9459 (comment)

That seems a little challenging to set up. The simplest (well, definitely the quickest) thing to do is probably just to mark those dependencies as missing so that pytype treats them as having default stubs

I think this is great to unblock us right now. I'll just note that this means, at the moment, stubs-only packages (or top-level c-modules described by .pyi files) that would otherwise work will be considered "missing" by pytype (for example: lxml-stubs).

@rchen152 rchen152 marked this pull request as ready for review January 10, 2023 21:56
@rchen152
Copy link
Collaborator Author

I think this is great to unblock us right now. I'll just note that this means, at the moment, stubs-only packages (or top-level c-modules described by .pyi files) that would otherwise work will be considered "missing" by pytype (for example: lxml-stubs).

Yep, that's the downside of this approach ^^; But pytype also still doesn't fully support PEP 561 (google/pytype#151), so this is all sort of a mess right now anyways and will need to be sorted out once we fix that issue.

Anyway, this PR should be ready now! (Assuming the last test that's still running passes.)

@AlexWaygood AlexWaygood merged commit 622a96b into main Jan 10, 2023
@AlexWaygood AlexWaygood deleted the pytype_test branch January 10, 2023 22:00
@AlexWaygood
Copy link
Member

Thanks so much for the quick response, as ever, @rchen152!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants