-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytype_test: Mark typeshed-external dependencies as missing. #9486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (once the new pytype release is out).
I think adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! (Ignore my earlier bogus comment that I deleted)
I think this is great to unblock us right now. I'll just note that this means, at the moment, stubs-only packages (or top-level c-modules described by |
Yep, that's the downside of this approach ^^; But pytype also still doesn't fully support PEP 561 (google/pytype#151), so this is all sort of a mess right now anyways and will need to be sorted out once we fix that issue. Anyway, this PR should be ready now! (Assuming the last test that's still running passes.) |
Thanks so much for the quick response, as ever, @rchen152! |
No description provided.