Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING: Note no bytearray promotion #9005

Merged
merged 3 commits into from
Oct 28, 2022
Merged

CONTRIBUTING: Note no bytearray promotion #9005

merged 3 commits into from
Oct 28, 2022

Conversation

JelleZijlstra
Copy link
Member

Closes #9001

hauntsaninja
hauntsaninja approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worth mentioning the _typeshed buffer types?

JelleZijlstra
JelleZijlstra commented Oct 28, 2022
View reviewed changes
@hauntsaninja hauntsaninja merged commit b5c4580 into master Oct 28, 2022
@hauntsaninja hauntsaninja deleted the JelleZijlstra-patch-1 branch October 28, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assume there is no bytes/bytearray/memoryview implicit promotion
2 participants
@JelleZijlstra @hauntsaninja