sqlite3: Avoid optional type for 'description' #7842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `| Any` trick instead, since it seems that in a lot of code the value can be predicted to be non-`None` (if a query has been executed previously, I think). The original type generated false positives in internal code. The docs don't mention the possibility of this being `None`, so it seems likely that a lot of code doesn't check for it: https://docs.python.org/3/library/sqlite3.html#sqlite3.Cursor.description
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
May 16, 2022
JukkaL
added a commit
to python/mypy
that referenced
this pull request
May 16, 2022
* gettext: Make GNUTranslations.CONTEXT not final (python/typeshed#7841) * sqlite3: Avoid optional type for 'description' (python/typeshed#7842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
| Anytrick instead, since it seems that in a lot ofcode the value can be predicted to be non-
None(if a queryhas been executed previously, I think).
The original type generated false positives in internal code.
The docs don't mention the possibility of this being
None, soit seems likely that a lot of code doesn't check for it:
https://docs.python.org/3/library/sqlite3.html#sqlite3.Cursor.description