Do not use ClassVar
s with generic variables
#6348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes:
pointer
Array
But, they are different. Let's see why.
pointer
Docs: https://docs.python.org/3/library/ctypes.html#ctypes.pointer
This looks like an instance attribute to me.
Array
Docs: https://docs.python.org/3/library/ctypes.html#ctypes.Array
In this case it is even more cryptic.
Array
is not used directly most of the time as far as I know.Moreover,
Array
is an abstract class in runtime (but not in typeshed).I will open a new issue for this.
Docs suggest to follow this practice to create new Array subtypes:
What really happens is we create a new type for each
*
, in this case:POINT_Array_3
.Closes #6333