Remove Jinja2 #5666
Closed
Remove Jinja2 #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure I understand the tests. But, does it mean that the typeshed annotations must be kept as they are a dependency on flask annotations? And we can't test flask against the actual jinja2 library? |
|
Or, rather, that I just need to put some additional annotations into flask to cover the now missing jinja annotations? |
|
Our policy is to keep the stubs around for at least six months for the benefit of users of older versions (https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#third-party-library-removal-policy). Looks like Jinja2 3 was released in May, so that's some time away. #5618 has discussion of how to make stub packages depend on non-stub packages. |
|
No problem. |
|
Also a duplicate of #5423, so we have our eyes on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like v3 includes type annotations now. Should this be removed from typeshed?