-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.5 #4675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Looks good as far as I can tell.
I don't have a good sense of when the right time to start burying 3.5's corpse is, so trusting you on that. It looks like we waited four months past EOL for 3.4.
Note @JukkaL expressed some reluctance recently: python/mypy#9536 (comment) For mypy, 3.5 seems to account for only a small share of downloads (although we don't know what version of Python people are targetting).
In terms of precedent setting, time will tell, but I think we might want to be a little slower when 3.6's time comes.
The decision to drop 3.5 support in typeshed can be orthogonal to the decision to drop 3.5 support in mypy, I think. Type checking Python 3.5 code will be possible (though somewhat limited) even without explicit support in typeshed. Mypy just won't be able to flag uses of Python 3.6 library features when targeting 3.5. Almost all changes in 3.6 seem to add new functionality instead of removing existing functionality or modifying things in incompatible ways. Starting from the next mypy release, I'm fine with 3.5 support being incomplete. The main thing is being able to run mypy using Python 3.5 when that's what ships with the operating system. |
I'm OK with doing this, but there's a ton of merge conflicts. |
Python 3.5 EOL was on 2020-09-30.
This comment has been minimized.
This comment has been minimized.
@JelleZijlstra I rebased the PR on current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but do you know what's going on with mypy-primer here?
Oh, I guess that might just have been because of a bad merge that produced syntax errors in a few files. |
Python 3.5 EOL was on 2020-09-30.