Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust isort config #4290

Merged
merged 3 commits into from
Jun 29, 2020
Merged

adjust isort config #4290

merged 3 commits into from
Jun 29, 2020

Conversation

JelleZijlstra
Copy link
Member

Fixes #4288.

  • Default imports to THIRD_PARTY, so in effect we merge the FIRST_PARTY and THIRD_PARTY stubs. This means
    import order is no longer affected by whether typing_extensions is installed locally.
  • Treat typing_extensions and _typeshed as standard library modules.

Note that isort master is very different from the latest release; we'll have to do something
different if and when the next isort release comes out.

Fixes python#4288.

- Default imports to THIRD_PARTY, so in effect we merge the FIRST_PARTY and THIRD_PARTY stubs. This means
  import order is no longer affected by whether typing_extensions is installed locally.
- Treat typing_extensions and _typeshed as standard library modules.

Note that isort master is very different from the latest release; we'll have to do something
different if and when the next isort release comes out.
@hauntsaninja hauntsaninja merged commit 0142a87 into python:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change isort config and turn on isort in CI
2 participants