collections/typing: fix various arg names #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2020 01:14
This feels nervous, but if it passes unit tests it's unlikely to break anything
| @@ -302,15 +302,15 @@ class Sequence(_Collection[_T_co], Reversible[_T_co], Generic[_T_co]): | |||
| @abstractmethod | |||
| def __getitem__(self, s: slice) -> Sequence[_T_co]: ... | |||
| # Mixin methods | |||
| def index(self, x: Any, start: int = ..., end: int = ...) -> int: ... | |||
| def count(self, x: Any) -> int: ... | |||
| def index(self, value: Any, start: int = ..., stop: int = ...) -> int: ... | |||
There was a problem hiding this comment.
A lot of these should probably also be positional-only.
There was a problem hiding this comment.
Ideally, yeah. Note that the actual classes in collections.abc don't use positional-only args though, so that would diverge from CPython
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jun 23, 2020
Change this so we can land python/typeshed#4258
|
@JelleZijlstra running into a mypy conflict, would you be willing to merge this and python/mypy#9037? |
JelleZijlstra
added a commit
to JelleZijlstra/mypy
that referenced
this pull request
Jun 28, 2020
Prepare for merge dance on python/typeshed#4258
|
Yes, starting now with an initial typeshed sync in mypy. |
JelleZijlstra
added a commit
to python/mypy
that referenced
this pull request
Jun 28, 2020
Prepare for merge dance on python/typeshed#4258
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Jun 28, 2020
Change this so we can land python/typeshed#4258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels nervous, but if it passes unit tests it seems unlikely to
break things