pkg_resources: Remove stray Anys and use more Self & NoReturn types
#11528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Mar 4, 2024
|
|
||
| class ResolutionError(Exception): ... | ||
|
|
||
| class DistributionNotFound(ResolutionError): | ||
| def __init__(self, req: Requirement, requirers: set[str] | None, /, *args: object) -> None: ... |
There was a problem hiding this comment.
ResolutionError subclasses still work with any number of arguments which will show up in the __repr__ string
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Mar 4, 2024
| @@ -333,7 +333,7 @@ class NullProvider: | |||
| def metadata_isdir(self, name: str) -> bool: ... | |||
| def resource_listdir(self, resource_name) -> list[str]: ... | |||
| def metadata_listdir(self, name: str) -> list[str]: ... | |||
| def run_script(self, script_name: str, namespace: Mapping[str, object]) -> None: ... | |||
| def run_script(self, script_name: str, namespace: dict[str, Any]) -> None: ... | |||
There was a problem hiding this comment.
Taken from
Lines 1330 to 1331 in 35b74bc
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from, and improved over #11455
Works towards #9550