Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows checks from curses #11241

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Remove Windows checks from curses #11241

merged 7 commits into from
Apr 6, 2024

Conversation

rmccampbell
Copy link
Contributor

Curses is available on Windows through a patch via the windows-curses package. See discussion in #6749.

This comment has been minimized.

@JelleZijlstra
Copy link
Member

Could you add some comments explaining the unusual situation here? (#6749 (comment))

@rmccampbell
Copy link
Contributor Author

Sure, I already added a comment in _curses.pyi but I'll add one in the top-level module too.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking merging for now, pending the outcome of the discussion in #6749. I'm not convinced that unconditionally making curses available on Windows in the right course of action.

@Akuli
Copy link
Collaborator

Akuli commented Mar 24, 2024

I think we should just fix the conflicts and merge this. After a couple months of no progress, it seems like the "right" thing won't happen any time soon, and it's time to instead go with the practical thing and just give people the autocompletions and type checking they want.

We can always come up with a better solution for specifying platforms later, and add back the if statements if it then makes sense.

@TheStef56
Copy link

TheStef56 commented Apr 6, 2024

Why is this pr still open and the check for windows in _curses.pyi if sys.platform != win32 hasn't been removed yet?

@srittau srittau dismissed their stale review April 6, 2024 12:26

Unblocking.

@Akuli
Copy link
Collaborator

Akuli commented Apr 6, 2024

This is easiest to review locally by telling git to ignore whitespace:

$ git diff -w origin/main HEAD

Copy link
Contributor

github-actions bot commented Apr 6, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and sorry it took us so long :)

@Akuli Akuli merged commit 5e2f741 into python:main Apr 6, 2024
55 checks passed
@TheStef56
Copy link

Thanks for doing this, and sorry it took us so long :)

Thank you for having listened to us Windows programmers 👍🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants