-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Windows checks from curses #11241
Conversation
This comment has been minimized.
This comment has been minimized.
Could you add some comments explaining the unusual situation here? (#6749 (comment)) |
Sure, I already added a comment in _curses.pyi but I'll add one in the top-level module too. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Curses is available on Windows through a patch via the windows-curses package.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking merging for now, pending the outcome of the discussion in #6749. I'm not convinced that unconditionally making curses available on Windows in the right course of action.
I think we should just fix the conflicts and merge this. After a couple months of no progress, it seems like the "right" thing won't happen any time soon, and it's time to instead go with the practical thing and just give people the autocompletions and type checking they want. We can always come up with a better solution for specifying platforms later, and add back the if statements if it then makes sense. |
Why is this pr still open and the check for windows in _curses.pyi |
This is easiest to review locally by telling git to ignore whitespace:
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, and sorry it took us so long :)
Thank you for having listened to us Windows programmers 👍🏻🙏🏻 |
Curses is available on Windows through a patch via the windows-curses package. See discussion in #6749.