Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Bump fpdf2 to 2.7.5 #10533

Closed
wants to merge 2 commits into from
Closed

[stubsabot] Bump fpdf2 to 2.7.5 #10533

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 5, 2023

Release: https://pypi.org/pypi/fpdf2/2.7.5
Homepage: https://pyfpdf.github.io/fpdf2/
Repository: https://github.com/PyFPDF/fpdf2
Diff: py-pdf/fpdf2@2.7.4...2.7.5

Stubsabot analysis of the diff between the two releases:

  • 4 public Python files have been added: test/test_mirror.py, test/test_output.py, test/text_shaping/__init__.py, test/text_shaping/test_text_shaping.py.
  • 0 files included in typeshed's stubs have been deleted.
  • 19 files included in typeshed's stubs have been modified or renamed.
  • Total lines of Python code added: 2430.
  • Total lines of Python code deleted: 828.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/fpdf2/2.7.5
Homepage: https://pyfpdf.github.io/fpdf2/
Repository: https://github.com/PyFPDF/fpdf2
Diff: py-pdf/fpdf2@2.7.4...2.7.5

Stubsabot analysis of the diff between the two releases:
 - 4 public Python files have been added: `test/test_mirror.py`, `test/test_output.py`, `test/text_shaping/__init__.py`, `test/text_shaping/test_text_shaping.py`.
 - 0 files included in typeshed's stubs have been deleted.
 - 19 files included in typeshed's stubs have been modified or renamed.
 - Total lines of Python code added: 2430.
 - Total lines of Python code deleted: 828.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@github-actions github-actions bot added the bot: stubsabot 🤖 PRs created by stubsabot 🤖 label Aug 5, 2023
@JelleZijlstra JelleZijlstra reopened this Aug 5, 2023
@AlexWaygood
Copy link
Member

Looks like there's a stubtest crash in that CI failure there, that's fun

@JelleZijlstra
Copy link
Member

Something with a default value of None that's being passed to mypy's internal LiteralType constructor, which accepts only str/int/bool/float.

@AlexWaygood AlexWaygood added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Aug 10, 2023
@AlexWaygood AlexWaygood marked this pull request as draft August 10, 2023 12:12
@srittau
Copy link
Collaborator

srittau commented Aug 21, 2023

I can't reproduce the stubtest crash locally, something weird is going on.

@srittau
Copy link
Collaborator

srittau commented Aug 21, 2023

The error message is actually generated by mypyc, not by stubtest, so I suspect a mypyc bug. Giving up on debugging that ...

@AlexWaygood
Copy link
Member

I can't reproduce the stubtest crash locally, something weird is going on.

Interesting -- nor can I...

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 22, 2023

Aha. I can reproduce if I run stubtest using Python 3.9 or Python 3.10 (we're currently using Python 3.10 in CI), but not on Python 3.11. @srittau, which version of Python are you using locally?

@srittau
Copy link
Collaborator

srittau commented Aug 22, 2023

On the phone right now, but I think I tried it with python 3.11.

@AlexWaygood
Copy link
Member

Since the crash only occurs when stubtest is run using Python <=3.10, I experimented to see whether we could run stubtest on our third-party stubs using Python 3.11, instead of Python 3.10, which is what we currently use. Unfortunately, it looks like several of the packages we have stubs for still can't be installed on Python 3.11 yet: https://github.com/AlexWaygood/typeshed/actions/runs/5943151723

@AlexWaygood AlexWaygood added status: deferred Issue or PR deferred until some precondition is fixed and removed help wanted An actionable problem of low to medium complexity where a PR would be very welcome labels Aug 23, 2023
@AlexWaygood
Copy link
Member

(python/mypy#15933 should be included in mypy 1.6, and should fix the crash. Marking this as "deferred" for now.)

@srittau
Copy link
Collaborator

srittau commented Aug 24, 2023

Closing, because I messed with stubsabot by merging the main branch into this branch.

@srittau srittau closed this Aug 24, 2023
@srittau srittau deleted the stubsabot/fpdf2 branch August 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: stubsabot 🤖 PRs created by stubsabot 🤖 status: deferred Issue or PR deferred until some precondition is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants