Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openpyxl's workbook.pyi #10306

Closed
wants to merge 1 commit into from
Closed

Fix openpyxl's workbook.pyi #10306

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2023

Preperty active returns openpyxl.worksheet.worksheet.Worksheet or None. This can be seen from the source code:

    @property
    def active(self):
        """Get the currently active sheet or None

        :type: :class:`openpyxl.worksheet.worksheet.Worksheet`
        """
        try:
            return self._sheets[self._active_sheet_index]
        except IndexError:
            pass

_WorkbookChild does not have many of the attributes that Worksheet has.

Preperty `active` returns `openpyxl.worksheet.worksheet.Worksheet` or None.
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator

srittau commented Jun 12, 2023

Thank you for your contribution. Unfortunately, according to the implementation (and unlike what the docstring says), Workbook.active can be any kind of workbook child: Worksheet, WriteOnlyWorksheet, or Chartsheet. See also #9836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant