Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_UrlopenRet gives error that addinfourl has no attribute status #3026

Closed
ThrowsException opened this issue Jun 1, 2019 · 1 comment · Fixed by #3045
Closed

_UrlopenRet gives error that addinfourl has no attribute status #3026

ThrowsException opened this issue Jun 1, 2019 · 1 comment · Fixed by #3045
Labels
stubs: false positive Type checkers report false errors

Comments

@ThrowsException
Copy link

_UrlopenRet is defined _UrlopenRet = Union[_HTTPResponse, addinfourl] but addinfourl has to attribute status so when checking the status of an HTTPResponse you receive error: Item "addinfourl" of "Union[HTTPResponse, addinfourl]" has no attribute "status"

https://github.com/python/cpython/blob/3.7/Lib/urllib/response.py#L68-L80
@srittau
Copy link
Collaborator

srittau commented Jun 5, 2019

_UrlopenRet should probably just be changed to Any, until something like python/typing#566 is implemented.

@srittau srittau added size-small stubs: false positive Type checkers report false errors labels Jun 5, 2019
utkarsh2102 added a commit to utkarsh2102/typeshed that referenced this issue Jun 9, 2019
@utkarsh2102
request.pyi: Change Union[] -> Any for attributing status.
0c54094 
Fixes python#3026
@utkarsh2102 utkarsh2102 mentioned this issue Jun 9, 2019
Merged
srittau pushed a commit that referenced this issue Jun 13, 2019
@utkarsh2102 @srittau
request.pyi: Change Union[] -> Any for attributing status. (#3045)
8e7c328 
Fixes #3026
@francoisfreitag francoisfreitag mentioned this issue Dec 6, 2019
Merged
@hauntsaninja hauntsaninja mentioned this issue Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

request.pyi: Change Union[] -> Any for attributing status utkarsh2102/typeshed
2 participants
@srittau @ThrowsException