Skip to content

Commit

Permalink
Remove a default value in distutils
Browse files Browse the repository at this point in the history
Fixes #9799.

Stubtest started failing on our `setuptools` stubs because of a default value added to our stdlib `distutils` stubs. The reason for this is because our `setuptools` stubs erroneously claim here that the `setuptools._distutils.core.Distribution` class is the same as the stdlib `distutils.dist.Distribution` class:

https://github.com/python/typeshed/blob/06755e10ba0d39e7e4c18fcc2663d9da564a71ad/stubs/setuptools/setuptools/_distutils/core.pyi#L3

In actual fact, they're not, and they have different default values for this parameter. But reverting the addition of the default value is the simplest short-term fix for now.

(An alternative fix would be to just merge #9795.)
  • Loading branch information
AlexWaygood authored Feb 23, 2023
1 parent 06755e1 commit 897ede1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion stdlib/distutils/dist.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class Distribution:
def get_command_packages(self): ...
def get_command_class(self, command): ...
def reinitialize_command(self, command, reinit_subcommands: int = 0): ...
def announce(self, msg, level=2) -> None: ...
def announce(self, msg, level: int = ...) -> None: ...
def run_commands(self) -> None: ...
def run_command(self, command) -> None: ...
def has_pure_modules(self): ...
Expand Down

0 comments on commit 897ede1

Please sign in to comment.