Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate library/queue.po #187

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Translate library/queue.po #187

merged 10 commits into from
Sep 29, 2022

Conversation

allen91wu
Copy link
Collaborator

resolve #181

Preview

image

@mattwang44
Copy link
Collaborator

@jordanSu, would you be interested in reviewing this PR?

@jordanSu
Copy link
Contributor

@mattwang44 sorry for late reply, sure let me review this.

@mattwang44
Copy link
Collaborator

@jordanSu I've sent an invitation for joining this project (in order to set you as a reviewer) a while ago. Remember to confirm it (link).

@jordanSu
Copy link
Contributor

@jordanSu I've sent an invitation for joining this project (in order to set you as a reviewer) a while ago. Remember to confirm it (link).

@mattwang44 sorry for missing the invitation, I found the link has expired, could you kindly send me a new one? Thanks a lot!

@mattwang44
Copy link
Collaborator

@jordanSu just sent!

@mattwang44 mattwang44 requested a review from jordanSu January 17, 2022 05:03
@mattwang44
Copy link
Collaborator

mattwang44 commented Mar 17, 2022 •
edited
Loading

@jordanSu
Is there any chance you can finish reviewing this PR recently? It's fine if you need it to be assigned to another reviewer!

@jordanSu
Copy link
Contributor

@mattwang44 Sorry for late, I might not be able to review it recently, I think it would be better to assign this to another reviewer.
Sorry for making you guys wait🙇

@mattwang44
Copy link
Collaborator

@jordanSu NP! Thanks for the efforts. Look forward to seeing your contribution again!

@mattwang44 mattwang44 removed the request for review from jordanSu March 17, 2022 05:39
@StevenHsuYL StevenHsuYL self-requested a review July 2, 2022 14:57
StevenHsuYL
StevenHsuYL suggested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@StevenHsuYL StevenHsuYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幫忙 review 一下。
建議僅供參考，大多是閱讀流暢度的小建議，都可以再討論。 😃

library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated

#: ../../library/queue.rst:273
msgid ""
"A queue class for use in a multi-processing (rather than multi-threading) "
"context."
msgstr ""
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
msgstr "用於多元處理（而非多執行緒）上下文的佇列 class。"

Reference: 多元處理 wiki

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process 一詞目前多翻譯為行程

Suggested change
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
msgstr "用於多行程處理 (multi-processing)（而非多執行緒）情境 (context) 的佇列 class。"

@mattwang44
Copy link
Collaborator

幫忙 review 一下。 建議僅供參考，大多是閱讀流暢度的小建議，都可以再討論。 😃

感謝 Steven！這個 PR 我會接手處理

@mattwang44 mattwang44 self-assigned this Jul 5, 2022
@allen91wu
Copy link
Collaborator Author

Thanks for the review from Steven. I'm just updated the file from the review. Please have a look!

mattwang44
mattwang44 reviewed Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面 Steven 的 comment 還有一些沒修掉，要再請你檢查一下 🙏🏽

library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
library/queue.po Outdated Show resolved Hide resolved
@mattwang44 mattwang44 assigned allen91wu and unassigned mattwang44 Sep 26, 2022
@mattwang44
Copy link
Collaborator

@allen91wu 還差 FIFO 那段 (../../library/queue.rst:37) 的 消耗完 要改成 消耗
#187 (comment)

@allen91wu
Copy link
Collaborator Author

@mattwang44 感謝提醒，已經 push 修正過後的版本

mattwang44
mattwang44 previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
看 @StevenHsuYL 有沒有興趣再檢查一下~

StevenHsuYL
StevenHsuYL previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@StevenHsuYL StevenHsuYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with optional editing later). 👍

@allen91wu @StevenHsuYL
Update library/queue.po
306bb1a 
Co-authored-by: Steven Hsu <[email protected]>
@allen91wu allen91wu dismissed stale reviews from StevenHsuYL and mattwang44 via 306bb1a September 29, 2022 03:06
@allen91wu
Copy link
Collaborator Author

@mattwang44 @StevenHsuYL
I’m just updated the file from Steven’s suggestion. Please have a look.

@StevenHsuYL
Copy link
Contributor

@mattwang44 @StevenHsuYL I’m just updated the file from Steven’s suggestion. Please have a look.

line 360-371 好像重複貼上了，再麻煩修改一下，謝謝！

@allen91wu @StevenHsuYL
Update library/queue.po
b9abb51 
Co-authored-by: Steven Hsu <[email protected]>
mattwang44
mattwang44 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the great work!

@mattwang44 mattwang44 merged commit a67c64b into python:3.10 Sep 29, 2022
@allen91wu allen91wu deleted the translate-queue branch September 29, 2022 11:37
@CAM-Gerlach CAM-Gerlach mentioned this pull request Sep 29, 2022
Merged
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
@allen91wu @mattwang44 @StevenHsuYL
Translate library/queue.po (python#187)
b259524 
* Translate `library/queue.po`

* Translate `library/queue.po`

* update file from the review

* fix typo

* Update library/queue.po

Co-authored-by: Steven Hsu <[email protected]>

* Update library/queue.po

Co-authored-by: Steven Hsu <[email protected]>

* remove redundant part

Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
Co-authored-by: Steven Hsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@StevenHsuYL StevenHsuYL StevenHsuYL left review comments

@josix josix Awaiting requested review from josix

Assignees

@allen91wu allen91wu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/queue.po
4 participants
@allen91wu @mattwang44 @jordanSu @StevenHsuYL