-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 747: TypeExpr: Type Hint for a Type Expression #3798
Conversation
Also: * PEP 655: Remove gremlin character
Yes, Jelle will confirm in this PR.
Please open a new thread after the PEP is merged to the repo. That gives notice that there's a new PEP draft to be reviewed, and will make it more widely known: there are people not following that existing thread who will pay more attention to a new thread announcing a new PEP draft. |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
…g slash Previously a URL like the following was recognized: https://discuss.python.org/t/typeform-spelling-for-a-type-annotation-object-at-runtime/51435/7/ But the canonical URL actually has no trailing slash: https://discuss.python.org/t/typeform-spelling-for-a-type-annotation-object-at-runtime/51435/7 That canonical URL is now recognized.
…To until draft 3 link available.
Feedback applied:
One interesting thing I had to do was extend the linting infrastructure slightly to recognize discuss.python.org post links without a trailing slash (which is the format the web UI generates the links in by default). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a great writeup but I feel in places it goes into too much detail and specifies too many special cases.
The linter was working as expected: it's validating a It would happily accept thread URLs such as these, with or without a trailing slash:
Please can you revert the linter change and link to a thread URL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this PEP!
I can't change the URL of where draft 2 was introduced in the past, in the middle of an existing thread. Rounding that URL to point at the thread itself makes it more difficult to see where the draft was introduced, since the top of that thread is where draft 1 came from. For now I've reverted the linter change and altered the draft 2 URL to point to the non-canonical URL that continues to reference exactly where draft 2 originated. |
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
… trailing slash" This reverts commit 0bbbd9c.
…, and TypeIs are (not) valid - which aren't helpful
Specifically: * Removed 1 of 2 examples - The extra example wasn't necessary to illustrate the point * Removed a paragraph which looked like an extra requirement on runtime checkers, which isn't the focus of this PEP
…ons with X' sections
…nx reference." This reverts commit 1c6a7af.
(I'm still integrating feedback, including larger feedback that involves creating/reorganizing entire sections. I expect to post a new major revision to this PR in the next few days, with a comment explaining major changes made.) |
Also: * Stringified TypeExprs: Remove now-redundant section
…ssios in value expression contexts
…g redefined externally
…proposed but rejected syntax
I've pushed a new draft of this PEP, with the following major changes:
I've also reverted the PEP 12 changes in this PR, in favor of moving those changes to a different PR, so brettcannon and warsaw shouldn't need to stay subscribed here. |
Friendly ping to @JelleZijlstra to take a look at some of the new major changes in this PR for TypeExpr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a few small comments.
Co-authored-by: Jelle Zijlstra <[email protected]>
(All feedback from Jelle has now either been applied or responded to) |
Thanks @JelleZijlstra , @hugovk , and @AlexWaygood for providing feedback! I'll create a new discuss.python.org thread for this PEP within the next day or two. |
Also:
PEP 12: Explain how to use Intersphinx references. Mention that Typing docs can be referenced using them.CC sponsor @JelleZijlstra
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriateDF: There is a lint error on thePost-History
line which I don't know how to fix.github/CODEOWNERS
for the PEPStandards Track requirements
Python-Version
set to valid (pre-beta) future Python version, if relevantDiscussions-To
andPost-History
DF: After merging I plan to post to this existing thread, then make a small PR to link to the exact post.📚 Documentation preview 📚: https://pep-previews--3798.org.readthedocs.build/