Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 730: Revisions and clarifications following community discussion #3506

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Oct 23, 2023

Following community discussion, this PR updates PEP 730.

Summary:

  • Removal of the sys.implementation._simulator attribute, in favor of an attribute on platform.ios_ver()

  • Clarification and simplification of values returned by platform to be a closer match of os.uname()

  • Normalisation of spelling of ios in wheel tags and sysconfig definitions

  • Clarification of the use of the version number in wheel tags.

  • A revised approach to framework naming

  • Clarifications of the decision process around GNU compiler triples, universal wheels, and availability of an interactive REPL

  • Adds an open issue around availability of x86_64 hardware for buildbots.

  • Some minor typos

  • Change is either:

    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)


📚 Documentation preview 📚: https://pep-previews--3506.org.readthedocs.build/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of proofreading.

peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
@ned-deily
Copy link
Member

@mhsmith's suggested changes look reasonable to me. With them, this revision to the PEP looks to be in good shape for submission. Nice work!

@ned-deily ned-deily merged commit 4d14f7a into python:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants