PEP 495: Fix incorrect gap image #2965
Conversation
The SVG image in the "Mind the Gap" section (pep-0495-gap.svg) is incorrect. It is essentially the same as the the SVG image in the "In the Gap" section (pep-0495-fold.svg). This is a bug that dates back to the original commit on 2015-08-30 (814d372) that uploaded the both the PNG and SVG versions of the Fold and Gap images. The PNG version of the Gap image is correct, but the SVG version is incorrect. I believe this bug was invisible prior to 2022-04-23 because PEP 495 previously referenced the PNG versions of the images (pep-0495-gap.png, pep-0495-fold-2.png). Commit 28a5eb3 deleted the PNG images and changed the links in PEP 495 to point to the SVG versions. The replacement SVG image attached in this PR is a manual recreation of the PNG version of the Gap image that was deleted on 2022-04-23. It is not exactly the same, but I think it is close enough.
|
All commit authors signed the Contributor License Agreement. |
CAM-Gerlach
changed the title
There was a problem hiding this comment.
LGTM, thanks, though one minor quibble—could you reduce the density of the dots on the thin dotted bounding lines by at least half, to match the original? It makes them look substantially more prominent, and makes the sketch a little harder to quickly overall.
|
I'm using Google Draw as mentioned in #2965 and it provides only this density for "dotted lines". The other line types are variants of "dashed lines". I don't have access to any other draw program, unless you can suggest an alternative that doesn't cost money (I'd rather not spend money just for this bug). Now, for consistency, I'm willing to manually reproduce the Fold diagram (pep-0495-fold.svg) using the same Google Draw style. |
There was a problem hiding this comment.
Oh, right—I'd somehow assumed you were generating it using Matplotlib, Inkscape or by hand (all free alternatives you could consider looking in to in the future), even though you'd told me before you were using Google Draw. My mistake, sorry!
In any case, that's fine—LGTM, thanks.
CAM-Gerlach
dismissed
their stale review
Seems like the original SVG may be recoverable after all
|
FYI, seems like @abalkin may be able to retrieve the original SVG after all, which will match more closely and without the dotted line issue, so let's wait to see about that. |
|
Awesome |
The SVG image in the "Mind the Gap" section (pep-0495-gap.svg) was incorrect. It is essentially the same as the the SVG image in the "In the Gap" section (pep-0495-fold.svg). This is a bug that dates back to the original commit on 2015-08-30 (814d372) that uploaded the both the PNG and SVG versions of the Fold and Gap images. The PNG version of the Gap image is correct, but the SVG version is incorrect. The replacement SVG image attached in this PR is a manual recreation of the PNG version of the Gap image that was deleted on 2022-04-23. It is not exactly the same, but I think it is close enough.
The SVG image in the "Mind the Gap" section (pep-0495-gap.svg) is incorrect. It is essentially the same as the the SVG image in the "In the Gap" section (pep-0495-fold.svg). This is a bug that dates back to the original commit on 2015-08-30 (814d372) that uploaded the both the PNG and SVG versions of the Fold and Gap images. The PNG version of the Gap image is correct, but the SVG version is incorrect.
I believe this bug was invisible prior to 2022-04-23 because PEP 495 previously referenced the PNG versions of the images (pep-0495-gap.png, pep-0495-fold-2.png). Commit 28a5eb3 deleted the PNG images and changed the links in PEP 495 to point to the SVG versions.
The replacement SVG image attached in this PR is a manual recreation of the PNG version of the Gap image that was deleted on 2022-04-23. It is not exactly the same, but I think it is close enough.
Fixes #2959