Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 550: Fix footnotes #2751

Merged
merged 5 commits into from
Aug 17, 2022
Merged

PEP 550: Fix footnotes #2751

merged 5 commits into from
Aug 17, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 7, 2022

Fix these warnings by removing the orphaned references:

pep-0550.rst:1704: WARNING: Footnote [4] is not referenced.
pep-0550.rst:1718: WARNING: Footnote [11] is not referenced.
pep-0550.rst:1720: WARNING: Footnote [13] is not referenced.
pep-0550.rst:1722: WARNING: Footnote [14] is not referenced.
pep-0550.rst:1724: WARNING: Footnote [15] is not referenced.
pep-0550.rst:1726: WARNING: Footnote [16] is not referenced.

[4] was removed in 1b8728d ("PEP-0550 V4" #375)

And the others were removed in 09c05c8 ("pep-550: Full rewrite: v2." #344)


Also:

  • Remove redundant emacs metadata
  • Use plaintext literal block for ASCII diagram
  • Update link redirects/https

Preview

https://pep-previews--2751.org.readthedocs.build/pep-0550/

@hugovk hugovk added the bug label Aug 7, 2022
@hugovk hugovk requested a review from 1st1 as a code owner August 7, 2022 18:39
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one small comment, thanks @hugovk

Not worth renumbering the references on an old rejected PEP, I would think...

pep-0550.rst Outdated Show resolved Hide resolved
Co-authored-by: CAM Gerlach <[email protected]>
@hugovk hugovk merged commit 0d7637f into python:main Aug 17, 2022
@hugovk hugovk deleted the pep550-fix-footnotes branch August 17, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants