Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 689: Rename to "Unstable C API tier" #2576

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

encukou
Copy link
Member

@encukou encukou commented May 3, 2022

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 3, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

> The current wording is in the rationale section, which is
> setting out the justification for the proposal. To me, it
> seems odd to phrase it "We need <feature> because <thing>
> requires <requirement>, but we don't guarantee requirement.
>
> My suggested rephrasing more explicity spells out that we
> want to support <thing> properly, there is a reason the
> current state doesn't work (no guarantees at an API level
> of stability), and hence <feature> is needed that provides
> those guarantees.

- python#2559 (comment)
@AA-Turner
Copy link
Member

AA-Turner commented May 3, 2022

Edit: My email notification said I need to sign it, seems the bot updated the status already. Odd it popped up though, it hasn't done on recent PRs I've been a co-author for.

A

Comment on lines +99 to 100
Additions to the unstable tier will count as *stabilization*,
and will be allowed up to Release Candidate 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence now reads oddly, although it makes sense on the second reading (I think!)

A

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the terminology is not perfect -- there's something more unstable than the unstable API.
But as discussed in the thread, it's better than “semi-stable”.

pep-0689.rst Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <[email protected]>
@encukou encukou merged commit 5232fda into python:main May 4, 2022
@encukou encukou deleted the unstable-capi branch May 4, 2022 08:02
@encukou
Copy link
Member Author

encukou commented May 4, 2022

My email notification said I need to sign it, seems the bot updated the status already

Sorry for the noise. I tried to attribute the commit to you, but the bot didn't like it, so I force-pushed with myself as Author.
I mentioned you in the squashed commit message instead.

@CAM-Gerlach
Copy link
Member

@encukou You could use Co-authored-by: instead for that, in the future?

@AA-Turner
Copy link
Member

He did: 5232fda

PEP 689: Rename to "Unstable C API tier" (#2576)

Co-authored-by: Adam Turner <[email protected]>

(I don't know what happened with the CLA bot though, or if it will happen again)

A

@CAM-Gerlach
Copy link
Member

Perhaps it didn't like your GitHub autogenerated address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants