-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 1: Update "issue tracker" to link to GitHub Issues #2568
Conversation
with all the issues migrated to GitHub Issues, it makes sense now for PEP-1 to point to GitHub Issues over BPO
Yep, seems good. 👍 Might also be worth saying "pull request" rather than "patch submission". |
oh, good call! this could use a little wordsmithing. the current sentence is:
I think changing "patch submission" to "pull request" would cause more confusion, since pull requests are not created via the issue tracker (as perhaps patches were attached to BPO issue in the past). to make this accurate, we need to say something along these lines:
if this looks good, I'll update the PR with the changes. |
@itamaro that wording sounds good to me. |
On GitHub, the issue tracker manages pull requests too, so it's not terribly wrong. What about this slight change?
|
rephrase a sentence to more accurately describe the current GitHub-based workflow
thanks for the feedback and suggestions - update the PR and added a link to GitHub pull requests too |
That's better, though IMO that sentence can be made a lot simpler, and I don't know if its wise to push users directly to pull requests since any non-trivial change requires an issue. Also, due to the automatic re-wrapping to fit the hard breaks, it ends up touching a fairly substantial number of lines and is hard to see what was actually modified, What about this change as implemented on this branch instead? |
that looks good to me |
s/Small enhancements/Most enhancements/ in either version -- de facto only substantive changes go through the PEP process. A |
+0 to Cam's wording over the one proposed in this PR, +1 to the change in general. A |
Co-authored-by: CAM Gerlach <[email protected]>
After in-person discussion with @itamaro , he asked me to go ahead and push a commit with a slightly modified form of my proposed revision. |
Thanks @itamaro! A |
with all the issues migrated to GitHub Issues, it makes sense now for PEP-1 to point to GitHub Issues over BPO