-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue template to avoid useless issues #2492
Conversation
I'd clarify that this isn't for reporting bugs in Python, but that it's for bugs in documents. But yeah, I think this would be an improvement. |
Would some headings help? (This is for code, but for example.) On that
So shall we use the new |
@hugovk To my mind, it seems overkill for bugs in documentation. I assume that people reporting bugs here are experienced developers (if they follow the PEP1 process, i.e. they report only bugs), and they don't need such issue forms. What's your opinion on that? But if there's a consensus, I can update the template to use the yaml file. |
@@ -0,0 +1,23 @@ | |||
Issue tracker is **ONLY** used for reporting bugs on documents (PEPs), not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue tracker is **ONLY** used for reporting bugs on documents (PEPs), not | |
This issue tracker is **ONLY** used for reporting bugs on documents (PEPs), not |
@@ -0,0 +1,23 @@ | |||
Issue tracker is **ONLY** used for reporting bugs on documents (PEPs), not | |||
bugs in Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could link to https://devguide.python.org/tracker/ as the place to report bugs in Python (and let's call it CPython).
New features should be discussed according to the following process: | ||
[PEP 1](https://peps.python.org/pep-0001/#start-with-an-idea-for-python) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New features should be discussed according to the following process: | |
[PEP 1](https://peps.python.org/pep-0001/#start-with-an-idea-for-python) | |
New features should be discussed according to | |
[PEP 1](https://peps.python.org/pep-0001/#start-with-an-idea-for-python). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk To my mind, it seems overkill for bugs in documentation. I assume that people reporting bugs here are experienced developers (if they follow the PEP1 process, i.e. they report only bugs), and they don't need such issue forms. What's your opinion on that?
I've not used the new format yet. If it's only for forms, sure, this one is simple enough :)
### What did you spot, and where? | ||
|
||
### What did you expect to be changed? | ||
|
||
### Why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a bit of space for text entry:
### What did you spot, and where? | |
### What did you expect to be changed? | |
### Why? | |
### What did you spot, and where? | |
### What did you expect to be changed? | |
### Why? | |
A lot of them aren't, and many are experienced developers and still might gloss over the issue template. The main goal isn't to give contributors more boilerplate text to read, edit and delete (or ignore), which the Contributing Guide and PEP 1 (especially with #2378 ) already cover. Rather, it should be to provide clear, hard to miss, easy to use and actionable pre-triage, so they can understand at a glance whether their issue is appropriate here, and if not, where to take it—which is what the template chooser does.
Actually, no, the In summary, it gives users a set of short, simple and actionable options (that we configure) when clicking the |
I'd also suggest waiting just a bit until #2378 is merged (which maybe we can go ahead and do now, since every active PEP editor has now approved it and the last comments were addressed), since that changes and improves the existing text and provides new/updated sections that we can link to directly in PEP 1 and the contributing guide. |
I am not enthusiastic about this change. Inappropriate issues are rare and easily dealt with, and the proposed templates add more overhead for us maintainers to deal with and more boilerplate for new contributors to read. |
I'd suggest just ditching the template and adding the recommended an issue chooser instead, with one button to just open a blank issue with a line of text explaining what issues here are for (or perhaps one for PEP text issues and one for website issues, with perhaps a link of text each), and maybe a couple other options with links to other places, e.g. "Report a bug in Python" -> BPO/GH, "Propose a new idea" -> Python-Ideas/Discourse Ideas, etc. This is fairly simple for us to maintain, minimizes the text new users need to read to the most important few lines while ensuring they read it, and allows experienced users to go right to an issue with one click and no boilerplate. |
@vpoulailleau Would you like to make a fresh PR following CAM's suggestion? For reference, the CPython repo just added something a bit like this
Thanks! |
@hugovk @CAM-Gerlach OK, I'll do this this week. |
Many issues are useless and can be avoided with an issue template. This template would have avoided (among others):
#2491 #2486 #2469 #2100 #2076 #1898 #1867 #1747 #1273