Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 645: Mark as Standards Track PEP #2483

Closed
wants to merge 3 commits into from
Closed

PEP 645: Mark as Standards Track PEP #2483

wants to merge 3 commits into from

Conversation

davidfstr
Copy link
Contributor

No description provided.

@davidfstr davidfstr requested a review from gvanrossum as a code owner March 30, 2022 05:43
@hugovk
Copy link
Member

hugovk commented Mar 30, 2022

We could also fix the link to the reference implementation at the same time because CPython has since switched from master to main:

Broken link: python/cpython@master...MaggieMoss:new-optional-syntax-postfix

Fixed link: python/cpython@main...MaggieMoss:new-optional-syntax-postfix

-A reference implementation can be found `here <https://github.com/python/cpython/compare/master...MaggieMoss:new-optional-syntax-postfix>`_ [5].
+A reference implementation can be found `here <https://github.com/python/cpython/compare/main...MaggieMoss:new-optional-syntax-postfix>`_ [5].
 .. [5] Reference Implementation
-    (https://github.com/python/cpython/compare/master...MaggieMoss:new-optional-syntax-postfix)
+    (https://github.com/python/cpython/compare/main...MaggieMoss:new-optional-syntax-postfix)

(Although that [5] and the footnote reference are redundant and repeating the main link so could be removed.)

@davidfstr
Copy link
Contributor Author

Did apply the requested feedback.

CAM-Gerlach
CAM-Gerlach approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, following @hugovk 's suggested changes. @gvanrossum ?

@davidfstr davidfstr mentioned this pull request Apr 15, 2022
Merged
@davidfstr
Copy link
Contributor Author

This PR is superceded by #2529 .

@davidfstr davidfstr closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidfstr @hugovk @CAM-Gerlach @raghavthind2005 @the-knights-who-say-ni