Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 673: Fix syntax highlighting #2435

Merged
merged 1 commit into from
Mar 15, 2022
Merged

PEP 673: Fix syntax highlighting #2435

merged 1 commit into from
Mar 15, 2022

Conversation

AlexWaygood
Copy link
Member

Before:

image
image

After:

image
image

JelleZijlstra
JelleZijlstra approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! cc @pradeep90 @Gobot1234, but planning to merge this once the RTD preview is up

@JelleZijlstra
Copy link
Member

https://pep-previews--2435.org.readthedocs.build/pep-0673/#use-in-attribute-annotations looks great

@JelleZijlstra JelleZijlstra merged commit 09a93fb into python:main Mar 15, 2022
@AlexWaygood AlexWaygood deleted the 673 branch March 15, 2022 22:54
@AlexWaygood
Copy link
Member Author

Thanks @JelleZijlstra!

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @JelleZijlstra @the-knights-who-say-ni