PEP 673: Fix a couple of typos #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would have been possible here to change the bound of the TypeVar on line 495 to 'Shape', however I've opted to change the names of the definitions so that they match the later (similar) definitions of this protocol.
I'm guessing this was just a copy/pasta error or similar; there is no generic class named 'Foo' which is in scope here, however there is a 'Bar' that has just been defined and isn't yet used.
Gobot1234
approved these changes
Mar 11, 2022
CAM-Gerlach
changed the title
JelleZijlstra
approved these changes
Mar 12, 2022
|
Thanks for your fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Name protocol to match usage
It would have been possible here to change the bound of the
TypeVaron line 495 to 'Shape', however I've opted to change the names of the definitions so that they match the later (similar) definitions of this protocol.Fix example generic class name
I'm guessing this was just a copy/pasta error or similar; there is no generic class named 'Foo' which is in scope here, however there is a 'Bar' that has just been defined and isn't yet used.