Infra: Upload rendered PEPs as GitHub artifact #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The zip can be found from "Render PEPs" > Summary > Artifacts > 📦 peps:
https://github.com/python/peps/actions/runs/1965215444 |
|
Is there a way to set an expiration date (1 week?) -- I don't want to over-use any free resource. A |
|
Yes, we can set a retention period between 1 and 90 days: |
|
Thanks @hugovk ; this is very useful. I'd been thinking for a while of adding something similar, but just hadn't gotten around to it yet. |
|
@hugovk uploads take ~60s which means CI takes longer to pass for merging quick-fix PRs -- is there a way to speed it up at all? A |
|
Now we have RTD build previews (I wasn't expecting them to be ready so quick :), I think we can remove this artifact upload? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to python/cpython#30419.
Whilst we're deciding whether to use something like Read the Docs that builds hosted previews of PRs, we can use https://github.com/actions/upload-artifact to create a zip of the rendered PEPs built on the CI.
This makes testing/reviewing a bit easier: no need to checkout the branch and build locally. Also reviewable on mobile.