Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 681: Remove discussion of alternate form #2386

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Mar 7, 2022

Removed the "Alternate form" section and the mention of the alternate form in the "Reference Implementation" section.

Now that the dataclass_transform decorator is available in typing_extensions, the fact that Pyright supports the dundered alternate form (__dataclass_transform__) is not particularly interesting and has caused some reader confusion.

This needed to be removed before requesting PEP approval anyway.

cc: @davidfstr

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this was useful as an experimental measure but the discussion in the PEP is now confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants