Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 12: Update spacing/breaking conventions to match current practice #2374

Merged

Conversation

CAM-Gerlach
Copy link
Member

As proposed by @JelleZijlstra in this comment and widely agreed on there.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I might also want to drop the Emacs stanza but I have no real idea what it does.

@warsaw
Copy link
Member

warsaw commented Mar 1, 2022

I might also want to drop the Emacs stanza but I have no real idea what it does.

It sets up some file-specific settings in Emacs's indented-text mode, like the column to fill paragraphs in (70), to use two spaces at the end of sentences, and to use UTF-8 encoding. These were helpful way back in the day, but they are probably safe to get rid of. Us 3 Emacs users still out there can just use rst-mode now.

@CAM-Gerlach
Copy link
Member Author

I thought about that, but for obvious reasons I didn't want to be too bold here. But it makes good sense from your comments, since those are the same required settings that are no longer required here, and its one more chunk of boilerplate that future PEP authors needn't worry about any more (and of course, PEP authors can still add it to their PEPs, should they themselves need it—that's who it's for, after all). In any case, I've implemented it as requested.

pep-0012.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants