Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Update language on PEP-Delegate field #2256

Merged
merged 5 commits into from
Jan 20, 2022
Merged

PEP 1: Update language on PEP-Delegate field #2256

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6505ed
Update language on PEP-Delegate
willingc Jun 22, 2020
96c0efb
Add review feedback from @JelleZijlstra and @AA-Turner
willingc Jan 20, 2022
1abf29b
Update pep-0001.txt
warsaw Jan 20, 2022
d2fd3ae
Update pep-0001.txt
warsaw Jan 20, 2022
92f207d
Update pep-0001.txt
warsaw Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions pep-0001.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,14 +281,25 @@ notifying the PEP author(s) and giving them a chance to make revisions.
The final authority for PEP approval is the Steering Council. However, whenever
a new PEP is put forward, any core developer that believes they are suitably
experienced to make the final decision on that PEP may offer to serve as
the PEP-Delegate for that PEP, and they will then have the authority to approve
(or reject) that PEP. Individuals taking on this responsibility are free to seek
the PEP-Delegate for that PEP, and they will then have the
authority to approve (or reject) that PEP.
Comment on lines +284 to +285
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the PEP-Delegate for that PEP, and they will then have the
authority to approve (or reject) that PEP.
the PEP-Delegate for that PEP, and if approved by the Steering Council,
they will then have the authority to approve (or reject) that PEP.

Not sure if this is the proper wording, but I would be explicit here to clarify that the SC has to approve their offer, it isn't automatic upon offering (as the text here seems to imply).


The term "PEP-Delegate" is used under the Steering
Council governance model. The PEP's designated decision maker,
the "PEP-Delegate" with the Steering Council's support, is
recorded in the "PEP-Delegate" field in the PEP's header. For
Comment on lines +287 to +290
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The term "PEP-Delegate" is used under the Steering
Council governance model. The PEP's designated decision maker,
the "PEP-Delegate" with the Steering Council's support, is
recorded in the "PEP-Delegate" field in the PEP's header. For
The term "PEP-Delegate" is used under the Steering Council governance model
for the PEP's designated decision maker, as accepted by the Steering Council,
and recorded in the "PEP-Delegate" field in the PEP's header. For

I found the wording here a little choppy, redundant and hard to parse, and suggest a bit of a restructuring to improve this.

PEPs written prior to the Steering Council's governance model, the field name
Copy link
Member

@CAM-Gerlach CAM-Gerlach Jan 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PEPs written prior to the Steering Council's governance model, the field name
PEPs written prior to the Steering Council governance model, the field name

Nitpick, but the possessive implies that the Steering Council created the governance model, as opposed to itself being the name of the governance model itself

"BDFL-Delegate" will still be kept.
The terms PEP-Delegate and BDFL-Delegate may be used interchangeably in
discussion. PEP-Delegate is the preferred term under the Steering Council
governance model.
Comment on lines +293 to +295
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The terms PEP-Delegate and BDFL-Delegate may be used interchangeably in
discussion. PEP-Delegate is the preferred term under the Steering Council
governance model.
The term "BDFL-Delegate" is a legacy alias for PEP-Delegate, stemming from
the time when Python was led by a BDFL, but otherwise has the same meaning.

This emphasizes that BDFL-Delegate is a legacy alias and explains its origin, while being simpler and more direct and with less choppiness.


Individuals offering to serve as PEP-Delegate should notify the Steering
Council, PEP authors and PEP sponsor of their intent to self-nominate.
Individuals taking on this responsibility are free to seek
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Individuals taking on this responsibility are free to seek
Those taking on this responsibility are free to seek

Avoid repetition

additional guidance from the Steering Council at any time, and are also expected
to take the advice and perspectives of other core developers into account.

The designated decision maker for each PEP is recorded in the "PEP-Delegate"
header in the PEP.

Such self-nominations are accepted by default, but may be explicitly declined by
the Steering Council. Possible reasons for the Steering Council declining a
self-nomination as PEP-Delegate include, but are not limited to, perceptions of
Expand Down