-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 613: Loosen class scope restriction of explicit TypeAlias #2154
Conversation
As long as the conversation on typing-sig is still open I think we should leave this. Maybe change to Draft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I believe both pyre and pyright developers spoke up on typing-sig and approved of this idea.
I would recommend waiting a few days to land this, because it's possible that everyone will agree to relaxing things even more to the point where type aliases are also allowed inside functions. Then the whole scope restriction section could be struck.
I created #2158 - which I think we should prefer to this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure if this PR is still relevant, but I spotted a few minor grammar/typo issues in the added/changed content
I think this one deserves to be merged, given that (a) it's small and focused, (b) typing-sig folks agreed, and (c) this PEP is still young. CAM, do you have merge permissions on this repo? If not, at-mention me when it's ready to be merged. |
Co-authored-by: CAM Gerlach <[email protected]>
Thanks for the review! |
@nipunn1313 You're most welcome! @gvanrossum 🔔 🔔 🔔
No; I'm not a PEP editor, remember? 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @nipunn1313 !
CAM, do you want to be a PEP editor? You could replace Chris A (who's no longer active AFAICT). |
I kinda stepped back a bit after the dumpster fire of PEP 671. Would support CAM as a PEP editor, with or without me stepping down. |
I posted on https://github.com/orgs/python/teams/pep-editors the other day but clearly that's not an effective communication mechanism :) |
Indeed it is not. I received no notification. Let's move the discussion there though now that I've been alerted. |
(I figured it out. You have to watch the team. It's in the left sidebar of the team UI.) |
I didn't want to derail this issue and wasn't sure if I should wait on being notified of the result of the mentioned private discussion before prematurely responding, but given some time has passed, I figured I'd reply for the record. Wow, thanks @gvanrossum ! I am positively flattered that you'd ask, and would certainly be excited to join the PEP editor team, provided you all are okay with it. While I do have a background in this elsewhere, I know it is a significant step up in trust and responsibility for someone who hasn't been contributing for that long on this particular repo, and who isn't as much of a "known quantity" around here as perhaps others are (not to mention, I'm a bit of a "small fry" overall compared to all of you, heh). As such, I totally understand if anyone has reservations about going ahead with it for now, and would of course be happy to continue helping out with proofreading, formatting, copyediting and maintenance in the ways I can as a regular contributor if so. However, if you are all on board with it, then I'd be honored to officially join your number. Just let me know! Some general background about me, for anyone curious:
|
Per discussion on typing-sig
https://mail.python.org/archives/list/[email protected]/thread/CGOO7GPPECGMLFDUDXSSXTRADI4BXYCS/